lkml.org 
[lkml]   [2012]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 0/4] ACPI: hotplug messages improvement
Date
Hi Toshi,

Tested your patches on a KVM setup. Since all your acpi_pr* macros are in the error path, I didn't see an easy way to trigger them. Instead added an acpi_pr_err() message in the success path and tested out vcpu addition/deletion sequence. No regressions seen in the functional tests and the ACPI err message comes out on the console and message buffer with a valid ACPI device path.

Vijay

Tested-by: Vijay Mohan Pandarathil<vijaymohan.pandarathil@hp.com>


-----Original Message-----
From: Kani, Toshimitsu
Sent: Friday, July 20, 2012 9:54 AM
To: lenb@kernel.org; linux-acpi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org; joe@perches.com; bhelgaas@google.com; isimatu.yasuaki@jp.fujitsu.com; liuj97@gmail.com; srivatsa.bhat@linux.vnet.ibm.com; prarit@redhat.com; imammedo@redhat.com; Pandarathil, Vijaymohan R; Kani, Toshimitsu
Subject: [PATCH v2 0/4] ACPI: hotplug messages improvement

This patchset improves logging messages for ACPI CPU, Memory, and
Container hotplug notify handlers. The patchset introduces a set of
new macro interfaces, acpi_pr_<level>(), and updates the notify
handlers to use them. acpi_pr_<level>() appends "ACPI" prefix and
ACPI object path to the messages. This improves diagnostics in
hotplug operations since it identifies an object that caused an
issue in a log file.

v2:
- Set buffer.pointer to NULL in acpi_printk().
- Added acpi_pr_debug().

---
This patchset applies on top of the patch below.

[PATCH] ACPI: Add ACPI CPU hot-remove support
http://marc.info/?l=linux-acpi&m=134098193327362&w=2

---
Toshi Kani (4):
ACPI: Add acpi_pr_<level>() interfaces
ACPI: Update CPU hotplug messages
ACPI: Update Memory hotplug messages
ACPI: Update Container hotplug messages

---
drivers/acpi/acpi_memhotplug.c | 24 ++++++++++++------------
drivers/acpi/container.c | 6 +++---
drivers/acpi/processor_driver.c | 36 +++++++++++++++++++++---------------
drivers/acpi/utils.c | 34 ++++++++++++++++++++++++++++++++++
include/acpi/acpi_bus.h | 20 ++++++++++++++++++++
5 files changed, 90 insertions(+), 30 deletions(-)


\
 
 \ /
  Last update: 2012-07-25 09:01    [W:1.529 / U:1.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site