Messages in this thread | | | Date | Wed, 25 Jul 2012 14:16:44 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH v2 2/2] proc: do not allow negative offsets on /proc/<pid>/environ |
| |
On 07/24, Djalal Harouni wrote: > > static int mem_open(struct inode *inode, struct file *file) > { > - return __mem_open(inode, file, PTRACE_MODE_ATTACH); > + int ret = __mem_open(inode, file, PTRACE_MODE_ATTACH); > + > + /* OK to pass negative loff_t, we can catch out-of-range */ > + file->f_mode |= FMODE_UNSIGNED_OFFSET; > + > + return ret; > }
It could be even simpler, I meant
file->f_mode |= FMODE_UNSIGNED_OFFSET; return __mem_open(inode, file, PTRACE_MODE_ATTACH);
Never mind, this is very minor and the patch is already in -mm.
Oleg.
| |