Messages in this thread | | | Date | Tue, 24 Jul 2012 12:13:58 +0300 | From | Peter De Schrijver <> | Subject | Re: [PATCH 5/5] i2c: tegra: convert normal suspend/resume to *_noirq |
| |
On Mon, Jul 23, 2012 at 08:24:38PM +0200, Stephen Warren wrote: > On 07/10/2012 05:20 AM, Laxman Dewangan wrote: > > To provide the late suspend and early resume for i2c > > driver, convert the suspend/resume as > > suspend-> suspend_noirq > > resume -> resume_noirq > > > > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> > > Why do we need this change? > > IIRC, I proposed it before solely to solve some suspend/resume ordering > issues, and Colin Cross NAKd it. These days, deferred probe should make > this change unnecessary. >
How does deferred probe solve this? Iirc the problem is that i2c is needed to talk to the PMIC, so we need to make sure i2c is shutdown last because drivers might want to do regulator control in the suspend function.
Cheers,
Peter.
| |