lkml.org 
[lkml]   [2012]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] posix_types.h: make __NFDBITS match glibc definition
On Tue, Jul 24, 2012 at 11:20:11AM -0700, Linus Torvalds wrote:
> On Tue, Jul 24, 2012 at 11:12 AM, Josh Boyer <jwboyer@redhat.com> wrote:
> >
> > +#define __NFDBITS (8 * (int) sizeof(long int))
>
> I don't know if the type change is needed, but who the hell uses "long int"?

Not strictly, no. I believe in my brief tests, just the int cast was
sufficient. I can respin if you'd like. I probably need to anyway to
CC stable on this.

> Somebody is confused. Grepping the kernel sources, I am saddened to
> see any of these at all. I certainly would never want to add one.

Thoughtless copying on my part. Glibc actually uses sizeof(__fd_mask),
but that is a typedef long int. I'm pretty sure that varianet doesn't
make things better.

josh


\
 
 \ /
  Last update: 2012-07-24 21:01    [W:0.095 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site