Messages in this thread | | | From | KY Srinivasan <> | Subject | RE: [PATCH 10/17] Tools: hv: Gather ipv[4,6] gateway information | Date | Tue, 24 Jul 2012 17:17:23 +0000 |
| |
> -----Original Message----- > From: Olaf Hering [mailto:olaf@aepfle.de] > Sent: Tuesday, July 24, 2012 12:54 PM > To: Stephen Hemminger > Cc: KY Srinivasan; gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org; > devel@linuxdriverproject.org; virtualization@lists.osdl.org; apw@canonical.com; > netdev@vger.kernel.org; ben@decadent.org.uk > Subject: Re: [PATCH 10/17] Tools: hv: Gather ipv[4,6] gateway information > > On Tue, Jul 24, Stephen Hemminger wrote: > > > On Tue, 24 Jul 2012 09:01:34 -0700 > > "K. Y. Srinivasan" <kys@microsoft.com> wrote: > > > > > + memset(cmd, 0, sizeof(cmd)); > > > + strcat(cmd, "/sbin/ip -f inet route | grep -w "); > > > + strcat(cmd, if_name); > > > + strcat(cmd, " | awk '/default/ {print $3 }'"); > > > > > > Much simpler method: > > > > ip route show match 0/0 > > This also has the benefit that ip is not called with absolute path, now > that distros move binaries around.
I could have chosen to not specify the full path for the ip command and for that matter all the external scripts I invoke from the KVP daemon. Do you mind if I submitted a patch to get rid of the absolute paths in this code.
Stephen's suggestion is clearly simpler (I don't need to invoke awk to filter what we want). Steve, I could make this change as well as an additional patch.
Regards,
K. Y
| |