lkml.org 
[lkml]   [2012]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH] PWM: Add support for configuring polarity of PWM
    Date
    On Tue, Jul 24, 2012 at 01:22:49, Thierry Reding wrote:
    > On Mon, Jul 23, 2012 at 03:05:26PM +0000, Philip, Avinash wrote:
    > > On Mon, Jul 23, 2012 at 18:38:25, Thierry Reding wrote:
    > > > On Mon, Jul 23, 2012 at 12:51:11PM +0000, Philip, Avinash wrote:
    > > > > On Mon, Jul 23, 2012 at 14:00:32, Thierry Reding wrote:
    > > > > > On Wed, Jul 18, 2012 at 06:24:13PM +0530, Philip, Avinash wrote:
    > > > > > > /*
    > > > > > > * pwm_enable - start a PWM output toggling
    > > > > > > */
    > > > > > > @@ -37,6 +47,7 @@ struct pwm_chip;
    > > > > > > enum {
    > > > > > > PWMF_REQUESTED = 1 << 0,
    > > > > > > PWMF_ENABLED = 1 << 1,
    > > > > > > + PWMF_POLARITY_INVERSE = 1 << 2,
    > > > > >
    > > > > > This should be named PWMF_POLARITY_INVERSED for consistency.
    > > > >
    > > > > Ok I will correct it.
    > > > >
    > > > > > I'm not sure that we really need this flag, though. It isn't used anywhere. But
    > > > > > maybe you have a use-case in mind?
    > > > >
    > > > > It can be used to find the polarity of the PWM at runtime.
    > > >
    > > > Yes, but is there any use-case where this information would be required?
    > >
    > > It's been added as a feature enhancement. May be it can ignore?
    >
    > I think it can be removed for now. It can be added back if we ever
    > really need it.

    Ok. I will remove it.

    Thanks
    Avinash

    >
    > Thierry
    >



    \
     
     \ /
      Last update: 2012-07-24 09:01    [W:4.561 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site