Messages in this thread | | | Date | Fri, 20 Jul 2012 10:54:36 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] x86/tlb: fix allnoconfig building warning |
| |
On Fri, Jul 20, 2012 at 09:18:23AM +0800, Alex Shi wrote: > The incompatible parameter of flush_tlb_mm_range cause build warning. > Fix it by correct parameter. > > Reported-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> > Signed-off-by: Alex Shi <alex.shi@intel.com>
Thanks for this.
Btw, the patch Subject should say:
"[PATCH] x86, tlb: Fix flush_tlb_mm_range signature"
or
"[PATCH] x86, tlb: Fix non-SMP build warning"
or similar. Having "allnoconfig" in the name is a bit misleading as it is only one of the reasons why we build a !CONFIG_SMP kernel - this can happen with a randbuild too. And the hunk below touches the "#ifndef CONFIG_SMP" part of tlbflush.h...
So, long story short, hpa, can pls you correct this when applying?
> --- > arch/x86/include/asm/tlbflush.h | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h > index 621b959..4fc8faf 100644 > --- a/arch/x86/include/asm/tlbflush.h > +++ b/arch/x86/include/asm/tlbflush.h > @@ -105,10 +105,10 @@ static inline void flush_tlb_range(struct vm_area_struct *vma, > __flush_tlb(); > } > > -static inline void flush_tlb_mm_range(struct vm_area_struct *vma, > +static inline void flush_tlb_mm_range(struct mm_struct *mm, > unsigned long start, unsigned long end, unsigned long vmflag) > { > - if (vma->vm_mm == current->active_mm) > + if (mm == current->active_mm) > __flush_tlb(); > }
Thanks.
-- Regards/Gruss, Boris.
Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551
| |