lkml.org 
[lkml]   [2012]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] cpu: intel, amd: mask cleared cpuid features
> +					unsigned int *msr_ext_cpuid_mask)
> +{
> + unsigned int msr, msr_ext;
> +
> + msr = msr_ext = 0;
> +
> + switch (c->x86_model) {

You have to check the family too.

> +
> + return msr;
> +}
> +
> +static void __cpuinit intel_mask_cpu_caps(struct cpuinfo_x86 *c)
> +{
> + u32 low, high;
> + unsigned int msr_cpuid_mask, msr_ext_cpuid_mask;
> +
> + msr_cpuid_mask = intel_cpuid_mask_msr(c, &msr_ext_cpuid_mask);
> + if (msr_cpuid_mask) {
> + set_cpu_cap(c, X86_FEATURE_CPUIDMASK);
> +
> + rdmsr(msr_cpuid_mask, low, high);

And please use rdmsrl(), rdmsr() is so 90ies

Other than that patch looks good. I presume it will be useful for
other things than just migration too.

-Andi

--
ak@linux.intel.com -- Speaking for myself only


\
 
 \ /
  Last update: 2012-07-20 19:41    [W:0.153 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site