Messages in this thread | | | From | Betty Dall <> | Subject | Re: [PATCH] checkpatch: Add checks for do {} while (0) macro misuses | Date | Fri, 20 Jul 2012 14:40:46 +0000 (UTC) |
| |
Hi Joe,
Joe Perches <joe <at> perches.com> writes:
> > These types of macros should not be used for either a > single statement nor should the macro end with a semi-colon. > > Add tests for these conditions. > > Signed-off-by: Joe Perches <joe <at> perches.com> > --- > scripts/checkpatch.pl | 39 +++++++++++++++++++++++++++++++++++++++ > 1 files changed, 39 insertions(+), 0 deletions(-)
I reviewed this and tested it out on the qib.h file we were looking at yesterday and it worked well. I was worried about a nested do {} while(0), because it will match with the first while. Here is a test case: #define qib_devinfo(pcidev, fmt, ...) \ do { \ do { \ dev_info(&(pcidev)->dev, fmt, ##__VA_ARGS__); \ } while (0); \ } while (0)
Checkpatch.pl didn't complain about that one. Granted, it is a contrived test case. Your change will catch the real problems.
-Betty
| |