Messages in this thread | | | Date | Fri, 20 Jul 2012 10:48:31 +0100 | From | Alan Cox <> | Subject | Re: [patch] tty: handle NULL parameters in free_tty_struct() |
| |
On Fri, 20 Jul 2012 10:06:34 +0300 Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We sometimes pass NULL pointers to free_tty_struct(). One example where > it can happen is in the error handling code in pty_common_install(). > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Alan Cox <alan@linux.intel.com>
We probably shouldn't be passing NULLs there but making free_tty_struct(NULL) a no-op matches the kfree and other behaviours and is robust.
| |