Messages in this thread Patch in this message | | | Subject | Re: linux-next: build warnings after merge of the libata tree | From | Lin Ming <> | Date | Mon, 02 Jul 2012 12:31:19 +0800 |
| |
On Mon, 2012-07-02 at 13:54 +1000, Stephen Rothwell wrote: > Hi Lin, > > On Mon, 02 Jul 2012 11:21:58 +0800 Lin Ming <ming.m.lin@intel.com> wrote: > > > > Could you please send me your ppc64 .config? > > I'll do cross build on my x86 machine. > > Please just look at the code added in drivers/ata/libata.h. Hint: what > happens if CONFIG_ATA_ACPI is *not* defined? >
Hi Stephen,
Could you pick below fix? Thanks.
From cc270d0b3b132a37290db5fe3941361243540a18 Mon Sep 17 00:00:00 2001 From: Lin Ming <ming.m.lin@intel.com> Date: Mon, 2 Jul 2012 12:20:39 +0800 Subject: [PATCH] libata-acpi: add missing inlines in libata.h
Adds inline for ata_acpi_unregister/ata_acpi_bind/ata_acpi_unbind in drivers/ata/libata.h for !CONFIG_ATA_ACPI to fix below warnings.
warning: 'ata_acpi_unregister' defined but not used [-Wunused-function] warning: 'ata_acpi_bind' defined but not used [-Wunused-function] warning: 'ata_acpi_unbind' defined but not used [-Wunused-function]
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Lin Ming <ming.m.lin@intel.com> --- drivers/ata/libata.h | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ata/libata.h b/drivers/ata/libata.h index 44a7939..50e4dff 100644 --- a/drivers/ata/libata.h +++ b/drivers/ata/libata.h @@ -131,9 +131,9 @@ static inline void ata_acpi_on_disable(struct ata_device *dev) { } static inline void ata_acpi_set_state(struct ata_port *ap, pm_message_t state) { } static inline int ata_acpi_register(void) { return 0; } -static void ata_acpi_unregister(void) { } -static void ata_acpi_bind(struct ata_device *dev) { } -static void ata_acpi_unbind(struct ata_device *dev) { } +static inline void ata_acpi_unregister(void) { } +static inline void ata_acpi_bind(struct ata_device *dev) { } +static inline void ata_acpi_unbind(struct ata_device *dev) { } #endif /* libata-scsi.c */ -- 1.7.2.5
| |