Messages in this thread | | | Subject | Re: [PATCH] [Trivial] qib: fix an incorrect message | From | Joe Perches <> | Date | Thu, 19 Jul 2012 12:11:50 -0700 |
| |
On Thu, 2012-07-19 at 12:56 -0600, Betty Dall wrote: > Thanks for the comment Joe. It looks like Roland already accepted the > trivial change.
No worries.
> On Thu, 2012-07-19 at 11:03 -0700, Joe Perches wrote: > > On Thu, 2012-07-19 at 13:34 -0600, Betty Dall wrote: [] > > > diff --git a/drivers/infiniband/hw/qib/qib_pcie.c b/drivers/infiniband/hw/qib/qib_pcie.c > > [] > > > @@ -725,7 +725,7 @@ qib_pci_mmio_enabled(struct pci_dev *pdev) > > > static pci_ers_result_t > > > qib_pci_slot_reset(struct pci_dev *pdev) > > > { > > > - qib_devinfo(pdev, "QIB link_reset function called, ignored\n"); > > > + qib_devinfo(pdev, "QIB slot_reset function called, ignored\n"); > > > > These sorts of typos can be avoided by using "%s: ", __func__ > > > > qib_devinfo(pdev, "QIB %s: called, ignored\n", __func__); > > You are right about using __func__. That is what I use typically too. In > this file, none of the qib_devinfo() messages use __func__, so I stuck > with the trivial change for consistency. I could write another patch > that makes use of __func__ for all the appropriate qib_devinfo() calls > (there are 4 of them.) Do you think that is a worthwhile change? BTW, I > did review all the other qib_devinfo() calls to make sure they are using > the correct function names, and they look good.
Thanks for checking Betty.
It's hard for me to answer, I'm not the maintainer. Maybe Roland has a preference.
I'd probably rename qib_devinfo to qib_info or qib_pdev_info (adding an _ before info for consistency) and change the macro definitions removing the unnecessary do {} while (0).
Single statement macros don't need to be:
#define macro(fmt, ...) \ do { \ single_stmt(fmt, ##__VA_ARGS__); \ } while (0)
and are probably better as:
#define macro(fmt, ...) \ single_stmt(fmt, ##__VA_ARGS__)
cheers, Joe
| |