Messages in this thread | | | Date | Thu, 19 Jul 2012 13:16:18 +0300 | From | Avi Kivity <> | Subject | Re: [PATCH 08/10] KVM: introduce readonly_bad_hva |
| |
On 07/17/2012 05:45 PM, Xiao Guangrong wrote: > In the later patch, it indicates failure when we try to get a writable > hva from the readonly slot > > Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com> > --- > virt/kvm/kvm_main.c | 12 +++++++++++- > 1 files changed, 11 insertions(+), 1 deletions(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index b70f1a4..c056736 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -994,9 +994,19 @@ static inline unsigned long bad_hva(void) > return PAGE_OFFSET; > } > > +static inline unsigned long readonly_bad_hva(void) > +{ > + return PAGE_OFFSET + PAGE_SIZE; > +} > + > +static int kvm_is_readonly_bad_hva(unsigned long addr) > +{ > + return addr == readonly_bad_hva(); > +} > + > int kvm_is_error_hva(unsigned long addr) > { > - return addr == bad_hva(); > + return addr == bad_hva() || kvm_is_readonly_bad_hva(addr); > }
addr >= PAGE_OFFSET. Or change it to use -E*.
-- error compiling committee.c: too many arguments to function
| |