lkml.org 
[lkml]   [2012]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 1/6] mfd: tps6586x:use devm managed resources
On Tuesday 17 July 2012 10:23 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Tue, Jul 17, 2012 at 10:12:39AM +0530, Laxman Dewangan wrote:
>> On Tuesday 17 July 2012 01:31 AM, Mark Brown wrote:
>>> On Mon, Jul 16, 2012 at 12:21:45PM +0530, Laxman Dewangan wrote:
>
>> I think device_remove will get called before the managed resource
>> get freed.
>> So do we need to call disable_irq() in remove() to avoid any interrupts?
> That would be very rude if the IRQ happened to get shared, though that's
> not possible at the moment. In general it's pretty hard to use devm_
> IRQs safely, it's normally safest to avoid them due to the issues with
> ensuring that the interrupt handler is safe to be called even while the
> device is being torn down.

OK, then I will revert this specific change if it is not safe. I will
send the another patch (part of series v3 1/6) for this change only.


\
 
 \ /
  Last update: 2012-07-18 08:21    [W:0.046 / U:1.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site