lkml.org 
[lkml]   [2012]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 06/23] intel_ips: blacklist HP ProBook laptops
    Date
    From: Greg KH <gregkh@linuxfoundation.org>

    3.0-stable review patch. If anyone has any objections, please let me know.

    ------------------

    From: Takashi Iwai <tiwai@suse.de>

    commit 88ca518b0bb4161e5f20f8a1d9cc477cae294e54 upstream.

    intel_ips driver spews the warning message
    "ME failed to update for more than 1s, likely hung"
    at each second endlessly on HP ProBook laptops with IronLake.

    As this has never worked, better to blacklist the driver for now.

    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Matthew Garrett <mjg@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/platform/x86/intel_ips.c | 22 ++++++++++++++++++++++
    1 file changed, 22 insertions(+)

    --- a/drivers/platform/x86/intel_ips.c
    +++ b/drivers/platform/x86/intel_ips.c
    @@ -72,6 +72,7 @@
    #include <linux/string.h>
    #include <linux/tick.h>
    #include <linux/timer.h>
    +#include <linux/dmi.h>
    #include <drm/i915_drm.h>
    #include <asm/msr.h>
    #include <asm/processor.h>
    @@ -1505,6 +1506,24 @@ static DEFINE_PCI_DEVICE_TABLE(ips_id_ta

    MODULE_DEVICE_TABLE(pci, ips_id_table);

    +static int ips_blacklist_callback(const struct dmi_system_id *id)
    +{
    + pr_info("Blacklisted intel_ips for %s\n", id->ident);
    + return 1;
    +}
    +
    +static const struct dmi_system_id ips_blacklist[] = {
    + {
    + .callback = ips_blacklist_callback,
    + .ident = "HP ProBook",
    + .matches = {
    + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
    + DMI_MATCH(DMI_PRODUCT_NAME, "HP ProBook"),
    + },
    + },
    + { } /* terminating entry */
    +};
    +
    static int ips_probe(struct pci_dev *dev, const struct pci_device_id *id)
    {
    u64 platform_info;
    @@ -1514,6 +1533,9 @@ static int ips_probe(struct pci_dev *dev
    u16 htshi, trc, trc_required_mask;
    u8 tse;

    + if (dmi_check_system(ips_blacklist))
    + return -ENODEV;
    +
    ips = kzalloc(sizeof(struct ips_driver), GFP_KERNEL);
    if (!ips)
    return -ENOMEM;



    \
     
     \ /
      Last update: 2012-07-18 03:02    [W:4.034 / U:0.716 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site