lkml.org 
[lkml]   [2012]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 1/4] kvm: Extend irqfd to support level interrupts
From
Date
On Wed, 2012-07-18 at 00:26 +0300, Michael S. Tsirkin wrote:
> On Mon, Jul 16, 2012 at 02:33:47PM -0600, Alex Williamson wrote:
> > @@ -96,6 +183,9 @@ irqfd_shutdown(struct work_struct *work)
> > * It is now safe to release the object's resources
> > */
> > eventfd_ctx_put(irqfd->eventfd);
> > +
> > + _irq_source_put(irqfd->source);
> > +
> > kfree(irqfd);
> > }
> >
>
> Hang on, this is a bug I think. This is done asynchronously. So this
> means that I can assign MAX number of irqfds, then close one, and now
^^^^^^^^^^^^^^^^^^^^ What is this?
Do you mean max irq source ids?

> assign will fail because deassign did not get freed.
>
> Maybe we can solve this by flushing wq before assign?
> Looks a bit fragile but may be enough - need to document well.
>





\
 
 \ /
  Last update: 2012-07-18 00:42    [W:0.351 / U:1.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site