lkml.org 
[lkml]   [2012]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [alsa-devel] [PATCH 1/2] MFD: twl6040: Fix revision information
On 07/17/2012 08:39 AM, Rajeev kumar wrote:
>> #define TWL6040_REV_ES1_0 0x00
>> -#define TWL6040_REV_ES1_1 0x01
>> -#define TWL6040_REV_ES1_2 0x02
>> +#define TWL6040_REV_ES1_1 0x01 /* Rev ES1.1 and ES1.2 */
>> +#define TWL6040_REV_ES1_3 0x02
>>
>> #define TWL6040_IRQ_TH 0
>> #define TWL6040_IRQ_PLUG 1
>> diff --git a/sound/soc/codecs/twl6040.c b/sound/soc/codecs/twl6040.c
>> index a36e9fc..2786de2 100644
>> --- a/sound/soc/codecs/twl6040.c
>> +++ b/sound/soc/codecs/twl6040.c
>> @@ -653,7 +653,7 @@ int twl6040_get_hs_step_size(struct snd_soc_codec *codec)
>> {
>> struct twl6040 *twl6040 = codec->control_data;
>>
>> - if (twl6040_get_revid(twl6040)< TWL6040_REV_ES1_2)
>> + if (twl6040_get_revid(twl6040)< TWL6040_REV_ES1_3)
>
>
> Instead of doing this change why not you take a #define for revision and do
> if (twl6040_get_revid(twl6040)< TWL6040_REV)

ES1.1, ES1.2 of twl6040 have 2mV HS step. Newer revisions (ES1.3 of twl6040
and twl6041) have 1mV HS step.
Here the comment was correct, but the define name was incorrect.

>
> ~Rajeev
>
>> /* For ES under ES_1.3 HS step is 2 mV */
>> return 2;
>> else
>


--
Péter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-07-17 15:41    [W:0.164 / U:1.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site