lkml.org 
[lkml]   [2012]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC][PATCH 2/14] ARM: shmobile: Use names of power domains for adding devices to them
    Date
    From: Rafael J. Wysocki <rjw@sisk.pl>

    Make the power management code under arch/arm/mach-shmobile/ use
    names of power domains instead of pointers to domain objects for
    adding devices to the domains. This will allow us to put the
    domain objects into tables and register them all in one shot
    going forward.

    Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
    ---
    arch/arm/mach-shmobile/board-ap4evb.c | 14 +++---
    arch/arm/mach-shmobile/board-armadillo800eva.c | 6 +-
    arch/arm/mach-shmobile/board-mackerel.c | 24 +++++------
    arch/arm/mach-shmobile/include/mach/pm-rmobile.h | 4 -
    arch/arm/mach-shmobile/pm-rmobile.c | 4 -
    arch/arm/mach-shmobile/setup-r8a7740.c | 20 ++++-----
    arch/arm/mach-shmobile/setup-sh7372.c | 48 +++++++++++------------
    7 files changed, 60 insertions(+), 60 deletions(-)

    Index: linux/arch/arm/mach-shmobile/pm-rmobile.c
    ===================================================================
    --- linux.orig/arch/arm/mach-shmobile/pm-rmobile.c
    +++ linux/arch/arm/mach-shmobile/pm-rmobile.c
    @@ -149,12 +149,12 @@ void rmobile_init_pm_domain(struct rmobi
    __rmobile_pd_power_up(rmobile_pd, false);
    }

    -void rmobile_add_device_to_domain(struct rmobile_pm_domain *rmobile_pd,
    +void rmobile_add_device_to_domain(const char *domain_name,
    struct platform_device *pdev)
    {
    struct device *dev = &pdev->dev;

    - pm_genpd_add_device(&rmobile_pd->genpd, dev);
    + pm_genpd_name_add_device(domain_name, dev);
    if (pm_clk_no_clocks(dev))
    pm_clk_add(dev, NULL);
    }
    Index: linux/arch/arm/mach-shmobile/include/mach/pm-rmobile.h
    ===================================================================
    --- linux.orig/arch/arm/mach-shmobile/include/mach/pm-rmobile.h
    +++ linux/arch/arm/mach-shmobile/include/mach/pm-rmobile.h
    @@ -31,13 +31,13 @@ struct rmobile_pm_domain *to_rmobile_pd(

    #ifdef CONFIG_PM
    extern void rmobile_init_pm_domain(struct rmobile_pm_domain *rmobile_pd);
    -extern void rmobile_add_device_to_domain(struct rmobile_pm_domain *rmobile_pd,
    +extern void rmobile_add_device_to_domain(const char *domain_name,
    struct platform_device *pdev);
    extern void rmobile_pm_add_subdomain(struct rmobile_pm_domain *rmobile_pd,
    struct rmobile_pm_domain *rmobile_sd);
    #else
    #define rmobile_init_pm_domain(pd) do { } while (0)
    -#define rmobile_add_device_to_domain(pd, pdev) do { } while (0)
    +#define rmobile_add_device_to_domain(name, pdev) do { } while (0)
    #define rmobile_pm_add_subdomain(pd, sd) do { } while (0)
    #endif /* CONFIG_PM */

    Index: linux/arch/arm/mach-shmobile/board-mackerel.c
    ===================================================================
    --- linux.orig/arch/arm/mach-shmobile/board-mackerel.c
    +++ linux/arch/arm/mach-shmobile/board-mackerel.c
    @@ -1623,20 +1623,20 @@ static void __init mackerel_init(void)

    platform_add_devices(mackerel_devices, ARRAY_SIZE(mackerel_devices));

    - rmobile_add_device_to_domain(&sh7372_pd_a4lc, &lcdc_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a4lc, &hdmi_lcdc_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a4lc, &meram_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a4mp, &fsi_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a3sp, &usbhs0_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a3sp, &usbhs1_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a3sp, &nand_flash_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a3sp, &sh_mmcif_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a3sp, &sdhi0_device);
    + rmobile_add_device_to_domain("A4LC", &lcdc_device);
    + rmobile_add_device_to_domain("A4LC", &hdmi_lcdc_device);
    + rmobile_add_device_to_domain("A4LC", &meram_device);
    + rmobile_add_device_to_domain("A4MP", &fsi_device);
    + rmobile_add_device_to_domain("A3SP", &usbhs0_device);
    + rmobile_add_device_to_domain("A3SP", &usbhs1_device);
    + rmobile_add_device_to_domain("A3SP", &nand_flash_device);
    + rmobile_add_device_to_domain("A3SP", &sh_mmcif_device);
    + rmobile_add_device_to_domain("A3SP", &sdhi0_device);
    #if !defined(CONFIG_MMC_SH_MMCIF) && !defined(CONFIG_MMC_SH_MMCIF_MODULE)
    - rmobile_add_device_to_domain(&sh7372_pd_a3sp, &sdhi1_device);
    + rmobile_add_device_to_domain("A3SP", &sdhi1_device);
    #endif
    - rmobile_add_device_to_domain(&sh7372_pd_a3sp, &sdhi2_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a4r, &ceu_device);
    + rmobile_add_device_to_domain("A3SP", &sdhi2_device);
    + rmobile_add_device_to_domain("A4R", &ceu_device);

    hdmi_init_pm_clock();
    sh7372_pm_init();
    Index: linux/arch/arm/mach-shmobile/setup-sh7372.c
    ===================================================================
    --- linux.orig/arch/arm/mach-shmobile/setup-sh7372.c
    +++ linux/arch/arm/mach-shmobile/setup-sh7372.c
    @@ -1023,30 +1023,30 @@ void __init sh7372_add_standard_devices(
    platform_add_devices(sh7372_late_devices,
    ARRAY_SIZE(sh7372_late_devices));

    - rmobile_add_device_to_domain(&sh7372_pd_a3rv, &vpu_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a4mp, &spu0_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a4mp, &spu1_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a3sp, &scif0_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a3sp, &scif1_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a3sp, &scif2_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a3sp, &scif3_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a3sp, &scif4_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a3sp, &scif5_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a3sp, &scif6_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a3sp, &iic1_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a3sp, &dma0_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a3sp, &dma1_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a3sp, &dma2_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a3sp, &usb_dma0_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a3sp, &usb_dma1_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a4r, &iic0_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a4r, &veu0_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a4r, &veu1_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a4r, &veu2_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a4r, &veu3_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a4r, &jpu_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a4r, &tmu00_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a4r, &tmu01_device);
    + rmobile_add_device_to_domain("A3RV", &vpu_device);
    + rmobile_add_device_to_domain("A4MP", &spu0_device);
    + rmobile_add_device_to_domain("A4MP", &spu1_device);
    + rmobile_add_device_to_domain("A3SP", &scif0_device);
    + rmobile_add_device_to_domain("A3SP", &scif1_device);
    + rmobile_add_device_to_domain("A3SP", &scif2_device);
    + rmobile_add_device_to_domain("A3SP", &scif3_device);
    + rmobile_add_device_to_domain("A3SP", &scif4_device);
    + rmobile_add_device_to_domain("A3SP", &scif5_device);
    + rmobile_add_device_to_domain("A3SP", &scif6_device);
    + rmobile_add_device_to_domain("A3SP", &iic1_device);
    + rmobile_add_device_to_domain("A3SP", &dma0_device);
    + rmobile_add_device_to_domain("A3SP", &dma1_device);
    + rmobile_add_device_to_domain("A3SP", &dma2_device);
    + rmobile_add_device_to_domain("A3SP", &usb_dma0_device);
    + rmobile_add_device_to_domain("A3SP", &usb_dma1_device);
    + rmobile_add_device_to_domain("A4R", &iic0_device);
    + rmobile_add_device_to_domain("A4R", &veu0_device);
    + rmobile_add_device_to_domain("A4R", &veu1_device);
    + rmobile_add_device_to_domain("A4R", &veu2_device);
    + rmobile_add_device_to_domain("A4R", &veu3_device);
    + rmobile_add_device_to_domain("A4R", &jpu_device);
    + rmobile_add_device_to_domain("A4R", &tmu00_device);
    + rmobile_add_device_to_domain("A4R", &tmu01_device);
    }

    static void __init sh7372_earlytimer_init(void)
    Index: linux/arch/arm/mach-shmobile/board-ap4evb.c
    ===================================================================
    --- linux.orig/arch/arm/mach-shmobile/board-ap4evb.c
    +++ linux/arch/arm/mach-shmobile/board-ap4evb.c
    @@ -1461,14 +1461,14 @@ static void __init ap4evb_init(void)

    platform_add_devices(ap4evb_devices, ARRAY_SIZE(ap4evb_devices));

    - rmobile_add_device_to_domain(&sh7372_pd_a4lc, &lcdc1_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a4lc, &lcdc_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a4mp, &fsi_device);
    + rmobile_add_device_to_domain("A4LC", &lcdc1_device);
    + rmobile_add_device_to_domain("A4LC", &lcdc_device);
    + rmobile_add_device_to_domain("A4MP", &fsi_device);

    - rmobile_add_device_to_domain(&sh7372_pd_a3sp, &sh_mmcif_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a3sp, &sdhi0_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a3sp, &sdhi1_device);
    - rmobile_add_device_to_domain(&sh7372_pd_a4r, &ceu_device);
    + rmobile_add_device_to_domain("A3SP", &sh_mmcif_device);
    + rmobile_add_device_to_domain("A3SP", &sdhi0_device);
    + rmobile_add_device_to_domain("A3SP", &sdhi1_device);
    + rmobile_add_device_to_domain("A4R", &ceu_device);

    hdmi_init_pm_clock();
    fsi_init_pm_clock();
    Index: linux/arch/arm/mach-shmobile/setup-r8a7740.c
    ===================================================================
    --- linux.orig/arch/arm/mach-shmobile/setup-r8a7740.c
    +++ linux/arch/arm/mach-shmobile/setup-r8a7740.c
    @@ -688,16 +688,16 @@ void __init r8a7740_add_standard_devices

    /* add devices to PM domain */

    - rmobile_add_device_to_domain(&r8a7740_pd_a3sp, &scif0_device);
    - rmobile_add_device_to_domain(&r8a7740_pd_a3sp, &scif1_device);
    - rmobile_add_device_to_domain(&r8a7740_pd_a3sp, &scif2_device);
    - rmobile_add_device_to_domain(&r8a7740_pd_a3sp, &scif3_device);
    - rmobile_add_device_to_domain(&r8a7740_pd_a3sp, &scif4_device);
    - rmobile_add_device_to_domain(&r8a7740_pd_a3sp, &scif5_device);
    - rmobile_add_device_to_domain(&r8a7740_pd_a3sp, &scif6_device);
    - rmobile_add_device_to_domain(&r8a7740_pd_a3sp, &scif7_device);
    - rmobile_add_device_to_domain(&r8a7740_pd_a3sp, &scifb_device);
    - rmobile_add_device_to_domain(&r8a7740_pd_a3sp, &i2c1_device);
    + rmobile_add_device_to_domain("A3SP", &scif0_device);
    + rmobile_add_device_to_domain("A3SP", &scif1_device);
    + rmobile_add_device_to_domain("A3SP", &scif2_device);
    + rmobile_add_device_to_domain("A3SP", &scif3_device);
    + rmobile_add_device_to_domain("A3SP", &scif4_device);
    + rmobile_add_device_to_domain("A3SP", &scif5_device);
    + rmobile_add_device_to_domain("A3SP", &scif6_device);
    + rmobile_add_device_to_domain("A3SP", &scif7_device);
    + rmobile_add_device_to_domain("A3SP", &scifb_device);
    + rmobile_add_device_to_domain("A3SP", &i2c1_device);
    }

    static void __init r8a7740_earlytimer_init(void)
    Index: linux/arch/arm/mach-shmobile/board-armadillo800eva.c
    ===================================================================
    --- linux.orig/arch/arm/mach-shmobile/board-armadillo800eva.c
    +++ linux/arch/arm/mach-shmobile/board-armadillo800eva.c
    @@ -1181,10 +1181,10 @@ static void __init eva_init(void)

    eva_clock_init();

    - rmobile_add_device_to_domain(&r8a7740_pd_a4lc, &lcdc0_device);
    - rmobile_add_device_to_domain(&r8a7740_pd_a4lc, &hdmi_lcdc_device);
    + rmobile_add_device_to_domain("A4LC", &lcdc0_device);
    + rmobile_add_device_to_domain("A4LC", &hdmi_lcdc_device);
    if (usb)
    - rmobile_add_device_to_domain(&r8a7740_pd_a3sp, usb);
    + rmobile_add_device_to_domain("A3SP", usb);
    }

    static void __init eva_earlytimer_init(void)


    \
     
     \ /
      Last update: 2012-07-17 00:01    [W:3.393 / U:0.552 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site