lkml.org 
[lkml]   [2012]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC V4 3/3] kvm: Choose better candidate for directed yield
On 07/16/2012 06:07 AM, Avi Kivity wrote:

>> +{
>> + bool eligible;
>> +
>> + eligible = !vcpu->ple.cpu_relax_intercepted ||
>> + (vcpu->ple.cpu_relax_intercepted&&
>> + vcpu->ple.dy_eligible);
>> +
>> + if (vcpu->ple.cpu_relax_intercepted)
>> + vcpu->ple.dy_eligible = !vcpu->ple.dy_eligible;
>
> Probably should assign 'true', since the previous value is essentially
> random.

I suspect the intended purpose of this conditional is to
flip the eligibility of a vcpu for being selected as a
direct yield target.

In other words, that bit of the code is correct.

--
All rights reversed


\
 
 \ /
  Last update: 2012-07-16 18:41    [W:0.062 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site