Messages in this thread | | | Date | Mon, 16 Jul 2012 02:58:18 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH TRIVIAL] mm: Fix build warning in kmem_cache_create() |
| |
On Sun, 15 Jul 2012, Shuah Khan wrote:
> I can work on reshuffling the code. Do have a question though. This > following sanity check is currently done only when CONFIG_DEBUG_VM is > defined. However, it does appear to be something that is that should be > checked even in regular path. > > struct kmem_cache *kmem_cache_create(const char *name, size_t size, > size_t align, > unsigned long flags, void (*ctor)(void *)) > { > struct kmem_cache *s = NULL; > > #ifdef CONFIG_DEBUG_VM > if (!name || in_interrupt() || size < sizeof(void *) || > size > KMALLOC_MAX_SIZE) { > printk(KERN_ERR "kmem_cache_create(%s) integrity check" > " failed\n", name); > goto out; > } > #endif >
Agreed, this shouldn't depend on CONFIG_DEBUG_VM.
| |