lkml.org 
[lkml]   [2012]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/6] drivers/net/can/softing/softing_main.c: ensure a consistent return value in error case
    I see the problem, and the solution. You may add
    Acked-by: Kurt Van Dijck <kurt.van.dijck@eia.be>

    On Sat, Jul 14, 2012 at 06:43:04PM +0200, Julia Lawall wrote:
    > From: Julia Lawall <Julia.Lawall@lip6.fr>
    >
    > Typically, the return value desired for the failure of a function with an
    > integer return value is a negative integer. In these cases, the return
    > value is sometimes a negative integer and sometimes 0, due to a subsequent
    > initialization of the return variable within the loop.
    >
    > A simplified version of the semantic match that finds this problem is:
    > (http://coccinelle.lip6.fr/)
    >
    > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
    >
    > ---
    > drivers/net/can/softing/softing_main.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/net/can/softing/softing_main.c b/drivers/net/can/softing/softing_main.c
    > index a7c77c7..f2a221e 100644
    > --- a/drivers/net/can/softing/softing_main.c
    > +++ b/drivers/net/can/softing/softing_main.c
    > @@ -826,12 +826,12 @@ static __devinit int softing_pdev_probe(struct platform_device *pdev)
    > goto sysfs_failed;
    > }
    >
    > - ret = -ENOMEM;
    > for (j = 0; j < ARRAY_SIZE(card->net); ++j) {
    > card->net[j] = netdev =
    > softing_netdev_create(card, card->id.chip[j]);
    > if (!netdev) {
    > dev_alert(&pdev->dev, "failed to make can[%i]", j);
    > + ret = -ENOMEM;
    > goto netdev_failed;
    > }
    > priv = netdev_priv(card->net[j]);
    >


    \
     
     \ /
      Last update: 2012-07-15 23:01    [W:3.107 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site