Messages in this thread | | | Date | Fri, 13 Jul 2012 08:46:39 +0900 | From | Chanwoo Choi <> | Subject | Re: [PATCH] extcon: Remove CONFIG_EXTCON_MODULE config to fix build break |
| |
On 07/13/2012 01:16 AM, Mark Brown wrote:
> On Thu, Jul 12, 2012 at 01:32:27PM +0900, Chanwoo Choi wrote: >> This patch modify 'Kconfig' of EXTCON Subsystem to support either >> active or inactive of EXTCON Subsystem. The various subsystem refer >> to EXTCON subsystem for controlling external connector, so core class >> of EXTCON should be included in kernel image. If EXTCON subsystem is >> builded with MODULE, other subsystem have build break because of >> linking the core class of EXTCON. > > By this logic very little in the kernel should be a module. We usually > only force things to be built in if there's a technical need for it like > init ordering constraints. Generally this is just a case of making sure > the Kconfig stuff is set up with appropriate dependencies.
As you said, I will fix it.
Thank you, Chanwoo Choi
| |