lkml.org 
[lkml]   [2012]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 166/187] raid5: delayed stripe fix
    Date
    From: Greg KH <gregkh@linuxfoundation.org>

    3.4-stable review patch. If anyone has any objections, please let me know.

    ------------------

    From: Shaohua Li <shli@kernel.org>

    commit fab363b5ff502d1b39ddcfec04271f5858d9f26e upstream.

    There isn't locking setting STRIPE_DELAYED and STRIPE_PREREAD_ACTIVE bits, but
    the two bits have relationship. A delayed stripe can be moved to hold list only
    when preread active stripe count is below IO_THRESHOLD. If a stripe has both
    the bits set, such stripe will be in delayed list and preread count not 0,
    which will make such stripe never leave delayed list.

    Signed-off-by: Shaohua Li <shli@fusionio.com>
    Signed-off-by: NeilBrown <neilb@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/md/raid5.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/md/raid5.c
    +++ b/drivers/md/raid5.c
    @@ -196,12 +196,14 @@ static void __release_stripe(struct r5co
    BUG_ON(!list_empty(&sh->lru));
    BUG_ON(atomic_read(&conf->active_stripes)==0);
    if (test_bit(STRIPE_HANDLE, &sh->state)) {
    - if (test_bit(STRIPE_DELAYED, &sh->state))
    + if (test_bit(STRIPE_DELAYED, &sh->state) &&
    + !test_bit(STRIPE_PREREAD_ACTIVE, &sh->state))
    list_add_tail(&sh->lru, &conf->delayed_list);
    else if (test_bit(STRIPE_BIT_DELAY, &sh->state) &&
    sh->bm_seq - conf->seq_write > 0)
    list_add_tail(&sh->lru, &conf->bitmap_list);
    else {
    + clear_bit(STRIPE_DELAYED, &sh->state);
    clear_bit(STRIPE_BIT_DELAY, &sh->state);
    list_add_tail(&sh->lru, &conf->handle_list);
    }



    \
     
     \ /
      Last update: 2012-07-13 02:01    [W:4.083 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site