lkml.org 
[lkml]   [2012]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3] panel: Use pr_err(...) rather than printk(KERN_ERR ...)
From
Ryan-san, Joe-san,

Thanks for your advice.
I will try re-create the patch again.

On Thu, Jul 12, 2012 at 2:43 PM, Joe Perches <joe@perches.com> wrote:
> On Thu, 2012-07-12 at 15:22 +1000, Ryan Mallon wrote:
>> On 12/07/12 12:35, Toshiaki Yamane wrote:
>> > This change is inspired by checkpatch.
>>
>> Your changelog needs to describe all of the changes you are making. The
>> subject line only describes one. This patch is doing the following:
>>
>> - Converting printk(KERN_ERR to pr_err
>> - Adding __func__ prefixes to printk lines
>> - Refactoring split printk strings onto a single line
>>
>> There are a few other printks in this file which could be converted to
>> pr_* to make the code more consistent. Perhaps a follow up patch?
>>
>> Typically for a sub-sequent version of a patch/series you should list
>> the changes since the last round. Put these below the --- so that they
>> don't become part of the change log, e.g.:
>>
>> Signed-off-by: Your name/email here
>> ---
>>
>> Changes since v2:
>> - Some stuff
>>
>> Changes since v1:
>> - Some other stuff
>>
>> Some more comments below.
>
> And ideally cc the people that gave you notes/comments
> on your previous patches too.
>



--

Regards,


.
.
...

Yamane Toshiaki

yamanetoshi@gmail.com


\
 
 \ /
  Last update: 2012-07-12 09:01    [W:0.041 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site