lkml.org 
[lkml]   [2012]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [trivial PATCH 2/7] ixgbe: remove unused #define
From
Date
On Tue, 2012-07-10 at 15:43 -0700, Jeff Kirsher wrote:
> On Tue, 2012-07-10 at 15:31 -0700, Jon Mason wrote:
> > Remove unused IXGBE_INTEL_VENDOR_ID #define
> >
> > Signed-off-by: Jon Mason <jdmason@kudzu.us>
> > Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> > Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
> > Cc: Bruce Allan <bruce.w.allan@intel.com>
> > Cc: Carolyn Wyborny <carolyn.wyborny@intel.com>
> > Cc: Don Skidmore <donald.c.skidmore@intel.com>
> > Cc: Greg Rose <gregory.v.rose@intel.com>
> > Cc: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
> > Cc: Alex Duyck <alexander.h.duyck@intel.com>
> > Cc: John Ronciak <john.ronciak@intel.com>
> > ---
> > drivers/net/ethernet/intel/ixgbe/ixgbe_type.h | 3 ---
> > 1 file changed, 3 deletions(-)
>
> This should also go through David Miller's networking tree's. Adding
> netdev mailing list.
>
> Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

After looking at this further, I rescind my ACK.

NAK, this define is used in several places in ixgbe_main.c and the
driver will not compile with this patch.

>
> >
> > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h b/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h
> > index 204848d..c8d8040 100644
> > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h
> > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h
> > @@ -32,9 +32,6 @@
> > #include <linux/mdio.h>
> > #include <linux/netdevice.h>
> >
> > -/* Vendor ID */
> > -#define IXGBE_INTEL_VENDOR_ID 0x8086
> > -
> > /* Device IDs */
> > #define IXGBE_DEV_ID_82598 0x10B6
> > #define IXGBE_DEV_ID_82598_BX 0x1508
>
>

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-07-12 20:43    [W:0.053 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site