Messages in this thread Patch in this message | | | Subject | [PATCH V2] checkpatch: Add check for use of sizeof without parenthesis | From | Joe Perches <> | Date | Wed, 11 Jul 2012 22:23:32 -0700 |
| |
Kernel style uses parenthesis around sizeof.
Signed-off-by: Joe Perches <joe@perches.com> --- Add check that works for sizeof *foo as well as sizeof foo
scripts/checkpatch.pl | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 7190f95..72c1803 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3265,6 +3265,12 @@ sub process { "sizeof(& should be avoided\n" . $herecurr); } +# check for sizeof without parenthesis + if ($line =~ /\bsizeof\s+((?:\*\s*|)$Lval|$Type(?:\s+$Lval|))/) { + WARN("SIZEOF_PARENTHESIS", + "sizeof $1 should be sizeof($1)\n" . $herecurr); + } + # check for line continuations in quoted strings with odd counts of " if ($rawline =~ /\\$/ && $rawline =~ tr/"/"/ % 2) { WARN("LINE_CONTINUATIONS",
| |