lkml.org 
[lkml]   [2012]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] staging/et131x: remove memset for the TCB
On Thu, Jul 12, 2012 at 11:54:28AM +0545, Devendra Naga wrote:
> TCB has kcalloc' ed so no need to call memset again on it.
>

Gar... What about when this is called from et131x_adjust_link() and
et1310_disable_phy_coma()?

Really this changelog is annoying. Based on the changelog I was
expecting the kcalloc() to be in the same function but it wasn't.
So then I have to redo all your work and check every code path. You
could have said what the code paths were in your description so I
don't have to grovel through it all myself.

regards,
dan carpenter




\
 
 \ /
  Last update: 2012-07-12 11:21    [W:0.051 / U:3.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site