Messages in this thread | | | Date | Wed, 11 Jul 2012 09:50:43 +0530 | Subject | Re: [PATCH 3/4] [SCSI] ufs: Add AMBA glue driver to ufshcd | From | vinayak holikatti <> |
| |
On Mon, Jul 2, 2012 at 8:50 PM, Arnd Bergmann <arnd@arndb.de> wrote: > On Monday 02 July 2012, Vinayak Holikatti wrote: >> +static struct amba_id ufshcd_amba_ids[] = { >> + { >> + /* Fake id for Primecell.*/ >> + .id = 0x00041FF0, >> + .mask = 0x000fffff, >> + }, >> + { 0, 0 }, >> +}; > > Hi Vinayak, > > Can you explain where this fake ID comes from? Is this ID actually > used by any hardware that is around somewhere? If not, I think it > would be better not to provide an AMBA driver at all, but instead > use the platform driver from patch 2 for all non-PCI uses. The fake ID is just a dummy ID. As you say, we will drop the amba driver for now. When primecell controller comes up, we will have the driver integrated. > > Arnd
| |