Messages in this thread | | | From | Krystian Garbaciak <> | Subject | Re: [PATCH] regulator: Fix bug in regulator_mode_to_status() core function. | Date | Wed, 11 Jul 2012 15:18:00 +0100 |
| |
> From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com] > Sent: 11 July 2012 14:29 > > On Wed, Jul 11, 2012 at 01:10:01PM +0100, Krystian Garbaciak wrote: > > Fix typo for case REGULATOR_STATUS_STANDBY -> REGULATOR_MODE_STANDBY. > > For undefined mode, return REGULATOR_STATUS_ERROR (0 is not valid status). > > This is deliberate. It's not reporting an error, it's reporting an > indeterminate status which is a different thing.
Ok, then I would propose to use REGULATOR_STATUS_OFF instead of 0, to present your deliberate decision here.
| |