lkml.org 
[lkml]   [2012]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/83] staging: comedi: rtd520: initial cleanup
On 2012-07-11 11:20, Ian Abbott wrote:
> On 2012-07-11 00:36, H Hartley Sweeten wrote:
> My main concern with this series of patches is they make it harder to
> determine what the register accesses actually do, mainly due to the
> removal of useful comments. For example:
>
> - RtdPacerStart(dev); /* Start PACER */
> + readl(devpriv->las0 + LAS0_PACER);
>
> And:
>
> - RtdPacerStop(dev); /* Stop PACER */
> + writel(0, devpriv->las0 + LAS0_PACER);

It would be too much work to redo all those patches though. I'll just
make a patch to add back in the useful-looking comments.

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-




\
 
 \ /
  Last update: 2012-07-11 13:21    [W:0.050 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site