Messages in this thread | | | Date | Wed, 11 Jul 2012 08:30:50 +0530 | From | Raghavendra K T <> | Subject | Re: [PATCH RFC V2 2/2] kvm PLE handler: Choose better candidate for directed yield |
| |
On 07/11/2012 02:20 AM, Ingo Molnar wrote: > > * Raghavendra K T<raghavendra.kt@linux.vnet.ibm.com> wrote: > >> --- a/virt/kvm/kvm_main.c >> +++ b/virt/kvm/kvm_main.c >> @@ -1595,6 +1595,9 @@ void kvm_vcpu_on_spin(struct kvm_vcpu *me) >> continue; >> if (waitqueue_active(&vcpu->wq)) >> continue; >> + if (!kvm_arch_vcpu_check_and_update_eligible(vcpu)) { >> + continue; >> + } > > Saw this fly by for a second time and now it annoyed me enough > to mention it: those curly braces are superfluous and should be > dropped. >
Oops! Sorry.will remove {} and resend with Rik's reviewed-by. TBH, block got simplified after iterations (local), this one leftout. my mistake.
| |