lkml.org 
[lkml]   [2012]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] net: cgroup: fix access the unallocated memory in netprio cgroup
于 2012年07月10日 19:08, Eric Dumazet 写道:
> On Tue, 2012-07-10 at 13:05 +0200, Eric Dumazet wrote:
>> On Tue, 2012-07-10 at 18:44 +0800, Gao feng wrote:
>>> there are some out of bound accesses in netprio cgroup.
>>
>>> - update_netdev_tables();
>>> + ret = extend_netdev_table(dev, max_len);
>>> + if (ret < 0)
>>> + goto out_free_devname;
>>> +
>>> ret = 0;
>>> rcu_read_lock();
>>> map = rcu_dereference(dev->priomap);
>>
>> Its unfortunately adding a bug.
>>
>> extend_netdev_table() is protected by RTNL.
>
> Please test your next patch using :
>
> CONFIG_LOCKDEP=y
> CONFIG_PROVE_RCU=y
>
> Because rtnl_dereference() should shout if you dont hold RTNL
>

Oops, I miss it.
Thanks Eric & Neil,I will test v3 patch with these two CONFIG.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-07-11 04:41    [W:0.041 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site