lkml.org 
[lkml]   [2012]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] KVM: X86: remove read buffer for mmio read
On 07/10/2012 04:01 PM, Gleb Natapov wrote:
> On Tue, Jul 10, 2012 at 03:50:39PM +0300, Avi Kivity wrote:
> > On 07/10/2012 01:48 PM, Gleb Natapov wrote:
> > > > > >
> > > > > But the code is already here, why drop it?
> > > >
> > > > The read cache is not effective for multiple disjunct reads.
> > > What do you mean?
> >
> > If an instruction reads from several sources in mmio, then the first
> > read will be flushed from the cache by the second read. So if we need a
> > third read, we'll have to exit for the first again.
> >
> The cache is flashed only before instruction decode, never during
> emulation.

Oh, I misread the code.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.



\
 
 \ /
  Last update: 2012-07-10 19:01    [W:0.048 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site