lkml.org 
[lkml]   [2012]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 24/24] TTY: use tty_port_register_device
On Sat, Jun 09, 2012 at 04:58:43PM +0200, Jiri Slaby wrote:
> On 06/04/2012 07:00 PM, Alan Cox wrote:
> >> In this patch we modify most of the drivers to do the latter. When the
> >> drivers use tty_register_device and we have tty_port already, we
> >> switch to tty_port_register_device. So we have the tty_struct =>
> >> tty_port link for free for those.
> >
> > Nice solution
>
> Seems so on the first glance... But it is racy. There is a window since
> tty_register_driver to tty_(port_)register_device where a node may be
> opened already, but tty_port won't be set up yet.
>
> The fix is to move cdev_add from tty_register_driver to
> tty_register_device, which makes sense anyway. Any objections?
>
> For the time being, Greg, please ignore 24/24 from these series (I see
> you haven't applied any of the patches yet.)

Ok, I'll drop 24/24. I should get to these this upcoming week as I am
finally going to be home from all of my crazy traveling.

greg k-h


\
 
 \ /
  Last update: 2012-06-09 20:21    [W:0.068 / U:1.768 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site