Messages in this thread | | | Subject | Re: Deadlock, L2TP over IP are not working, 3.4.1 | From | Eric Dumazet <> | Date | Fri, 08 Jun 2012 07:47:18 +0200 |
| |
On Fri, 2012-06-08 at 00:37 +0200, Francois Romieu wrote: > Eric Dumazet <eric.dumazet@gmail.com> : > [...] > > If LLTX is used, this means several cpus can execute this code at the > > same time. > > > > You need percpu stats, or use atomic primitives. > > Would adding percpu stats not be frown upon ? >
I have no idea how many l2tp_eth devices are setup at once in typical conf.
> As atomic will defeat the 64 bits stats on 32 bits, I should probably stick > to plain bh disabling lock. >
Not sure what you mean by "atomic will defeat the 64 bits stats on 32 bits", since you also need atomic for "32 bits stats" or "64 bits stats on 64 bit arches"
I personally would just use "unsigned long". If people want 64bit stats for their l2tp_eth, they certainly can use a 64bit host.
| |