Messages in this thread | | | Date | Fri, 8 Jun 2012 07:40:48 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH] x86,nmi: Fix section mismatch warnings on 32-bit |
| |
On Thu, Jun 07, 2012 at 10:06:54PM -0400, Don Zickus wrote: > On Tue, Jun 05, 2012 at 07:22:08PM +0200, Sam Ravnborg wrote: > > > >> I do not know enough about behind the scene compiler magic to track this > > > >> down correctly. So any insight/help is greatly appreciated. :-) > > > > > > > > We register a function annotated __init. And the normal use of this > > > > register() > > > > is for functions that survive the init phase. > > > > So drop the __init annotation on the function we register and the mismatch > > > > is fixed. > > > > > > But in the case here the function really is being used at init time > > > only. > > This is only for testing. Ando nly if CONFIG_DEBUG_NMI_SELFTEST is set. > > Hi Sam, > > Sorry for ignoring your responses before. Somehow your emails were not > hitting my inbox for some reason, but I found them in my lkml folder. > > So I am confused on the right way to fix this. > > Sam is saying drop the __init and Jan is suggesting add __initdata for > these two special cases. > > Anyone want to break the tie? :-)
IMO Jan's approach with __initdata is overkill, but I do not care much about it.
Sam
| |