Messages in this thread | | | Date | Fri, 8 Jun 2012 10:40:33 +0200 | From | Simon Baatz <> | Subject | Re: [PATCH] shmem: replace_page must flush_dcache and others |
| |
Hi Hugh,
On Thu, May 31, 2012 at 03:31:27PM -0700, Hugh Dickins wrote: > * shmem_replace_page must flush_dcache_page after copy_highpage [akpm]
> > - *pagep = newpage; > page_cache_get(newpage); > copy_highpage(newpage, oldpage); > + flush_dcache_page(newpage); >
Couldn't we use the lighter flush_kernel_dcache_page() here (like in fs/exec.c copy_strings())? If I got this correctly, the page is copied via the kernel mapping and thus, only the kernel mapping needs to be flushed.
- Simon
| |