lkml.org 
[lkml]   [2012]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] shmem: replace_page must flush_dcache and others
Hi Hugh,

On Thu, May 31, 2012 at 03:31:27PM -0700, Hugh Dickins wrote:
> * shmem_replace_page must flush_dcache_page after copy_highpage [akpm]

>
> - *pagep = newpage;
> page_cache_get(newpage);
> copy_highpage(newpage, oldpage);
> + flush_dcache_page(newpage);
>

Couldn't we use the lighter flush_kernel_dcache_page() here (like in
fs/exec.c copy_strings())? If I got this correctly, the page is
copied via the kernel mapping and thus, only the kernel mapping needs
to be flushed.

- Simon


\
 
 \ /
  Last update: 2012-06-08 11:21    [W:0.209 / U:2.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site