lkml.org 
[lkml]   [2012]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [linux-pm] Suspend/resume regressions on Lenovo S10-3
    On Wed, 6 Jun 2012, Rafael J. Wysocki wrote:

    > > --- a/drivers/acpi/processor_idle.c
    > > +++ b/drivers/acpi/processor_idle.c
    > > @@ -895,8 +895,9 @@ static int acpi_idle_enter_bm(struct cpuidle_device *dev,
    > > if (unlikely(!pr))
    > > return -EINVAL;
    > >
    > > -
    > > if (acpi_idle_suspend) {
    > > + local_irq_disable();
    > > + local_irq_enable();
    > > cpu_relax();
    > > return -EINVAL;
    > > }
    >
    > May I say this is ugly? Why can't we track the status of interrupts
    > properly here?

    It's not just ugly; it's illogical. What reason could there possibly
    be for disabling interrupts and then enabling them again without doing
    anything in between?

    Alan Stern



    \
     
     \ /
      Last update: 2012-06-07 05:02    [W:0.024 / U:31.596 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site