lkml.org 
[lkml]   [2012]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: processes hung after sys_renameat, and 'missing' processes
On Thu, Jun 07, 2012 at 02:54:10AM +0100, Al Viro wrote:

> > Do you even need the "dentry->d_parent != dentry" test? When do we
> > even rename root dentries?
>
> Root of the filesystem - never; root of disconnected subtree - sure,
> that's how they become connected to the tree. See d_materialize_unique(),
> for example...
>
> BTW, I really need more coffee - those checks belong in __d_move(),
> not d_move(); aforementioned d_materialize_unique() doesn't use d_move(),
> it calls __d_move() directly. Sorry.

np, I'll restart the build/test.

Dave



\
 
 \ /
  Last update: 2012-06-07 05:01    [W:0.052 / U:12.408 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site