Messages in this thread | | | Date | Wed, 6 Jun 2012 22:08:47 -0400 | From | Dave Jones <> | Subject | Re: processes hung after sys_renameat, and 'missing' processes |
| |
On Thu, Jun 07, 2012 at 02:54:10AM +0100, Al Viro wrote:
> > Do you even need the "dentry->d_parent != dentry" test? When do we > > even rename root dentries? > > Root of the filesystem - never; root of disconnected subtree - sure, > that's how they become connected to the tree. See d_materialize_unique(), > for example... > > BTW, I really need more coffee - those checks belong in __d_move(), > not d_move(); aforementioned d_materialize_unique() doesn't use d_move(), > it calls __d_move() directly. Sorry.
np, I'll restart the build/test.
Dave
| |