Messages in this thread Patch in this message | | | Date | Wed, 6 Jun 2012 00:08:45 -0700 | From | tip-bot for Srikar Dronamraju <> | Subject | [tip:perf/urgent] perf uprobes: Remove unnecessary check before strlist__delete |
| |
Commit-ID: a23c4dc422cff7bd30f40f5dc7c9ac4a6339005a Gitweb: http://git.kernel.org/tip/a23c4dc422cff7bd30f40f5dc7c9ac4a6339005a Author: Srikar Dronamraju <srikar@linux.vnet.ibm.com> AuthorDate: Thu, 31 May 2012 17:16:43 +0530 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Thu, 31 May 2012 12:08:49 -0300
perf uprobes: Remove unnecessary check before strlist__delete
Since strlist__delete() itself checks, the additional check before calling strlist__delete() is redundant.
No Functional change.
Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com> Suggested-by: Arnaldo Carvalho de Melo <acme@infradead.org> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> Cc: Anton Arapov <anton@redhat.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Steven Rostedt <rostedt@goodmis.org> Link: http://lkml.kernel.org/r/20120531114643.23691.38666.sendpatchset@srdronam.in.ibm.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/probe-event.c | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index 59dccc9..0dda25d 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c @@ -2164,16 +2164,12 @@ int del_perf_probe_events(struct strlist *dellist) error: if (kfd >= 0) { - if (namelist) - strlist__delete(namelist); - + strlist__delete(namelist); close(kfd); } if (ufd >= 0) { - if (unamelist) - strlist__delete(unamelist); - + strlist__delete(unamelist); close(ufd); }
| |