lkml.org 
[lkml]   [2012]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] NFC: Fix possible NULL ptr deref when getting the name of a socket
    Date
    llcp_sock_getname() might get called before the LLCP socket was created.
    This condition isn't checked, and llcp_sock_getname will simply deref a
    NULL ptr in that case.

    This exists starting with d646960 ("NFC: Initial LLCP support").

    Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
    ---
    net/nfc/llcp/sock.c | 3 +++
    1 files changed, 3 insertions(+), 0 deletions(-)

    diff --git a/net/nfc/llcp/sock.c b/net/nfc/llcp/sock.c
    index 3f339b1..17a707d 100644
    --- a/net/nfc/llcp/sock.c
    +++ b/net/nfc/llcp/sock.c
    @@ -292,6 +292,9 @@ static int llcp_sock_getname(struct socket *sock, struct sockaddr *addr,

    pr_debug("%p\n", sk);

    + if (llcp_sock == NULL)
    + return -EBADFD;
    +
    addr->sa_family = AF_NFC;
    *len = sizeof(struct sockaddr_nfc_llcp);

    --
    1.7.8.6


    \
     
     \ /
      Last update: 2012-06-06 23:41    [W:0.024 / U:30.128 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site