Messages in this thread | | | Date | Wed, 6 Jun 2012 15:33:19 +0900 | From | Greg Kroah-Hartmann <> | Subject | Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer |
| |
On Tue, May 29, 2012 at 06:07:00PM +0200, Kay Sievers wrote: > On Sun, 2012-05-27 at 16:23 +0200, Kay Sievers wrote: > > On Sat, May 26, 2012 at 1:11 PM, Anton Vorontsov <anton.vorontsov@linaro.org> wrote: > > > > So, starting from this patch every kmsg_dump user is getting the > > > binary stuff, which is barely usable, and breaks a longstanding > > > user-visible ABIs (e.g. mtdoops, oops dumping into nvram on PowerPC, > > > and ramoops of course). > > > > These cases export their own format, it's just that the dump routines > > could copy the buffer in only two steps (beginning and end of the ring > > buffer), while in the future their code would need an update to copy > > it record for record now. The exported format in the dump does not > > necessarily need to change. > > Here is an untested patch, which should restore the old plain text > export format of the kmsg buffer. I adds an iterator to the dumper > routine, which can be used by the dumper to properly copy the data out > of the kmsg record buffer. All current users are converted in the same > patch. > > Any feedback/help in testing/updating and getting this thing into a > mergeable state would be greatly appreciated.
Any comments on this patch? Did anyone try it out? I want to merge it now, so unless someone objects, will do so soon.
thanks,
greg k-h
| |