lkml.org 
[lkml]   [2012]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND PATCH] trivial: treewide: remove extra semicolon added by module_init/exit
On Wed, Jun 06, 2012 at 07:47:42AM -0700, Joe Perches wrote:
> On Wed, 2012-06-06 at 17:02 +0300, Felipe Balbi wrote:
> > The definition of module_init() and module_exit()
> > already added the final semicolon creating a situation
> > where most of our drivers end up with two semicolons
> > at the end of every module_init()/module_exit() call.
> >
> > To fix that, we add missing semicolons to the places
> > which didn't have them and remove the semicolons from
> > the definition of module_init/module_exit.
> >
> > Patch generated with the following sed script:
> >
> > $ sed -i 's/^module_\(init\|exit\)\s*\((\w\+)\)$/module_\1\2;/g' \
> > $(git ls-files)
>
> I don't think that script works completely.
> It doesn't find the module_init in fs/autofs4/init.c

hehe, there's a trailing whitespace at the end of that module_init()
call. Will fix the patch and resend.

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-06-06 18:41    [W:0.763 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site