lkml.org 
[lkml]   [2012]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] mtip32xx: Remove 'registers' and 'flags' from sysfs
On Tue, Jun 05, 2012 at 11:18:15AM -0700, Asai Thambi S P wrote:
> On 6/5/2012 2:33 AM, Greg KH wrote:
>
> > On Mon, Jun 04, 2012 at 12:43:03PM -0700, Asai Thambi S P wrote:
> >>
> >> This patch removes entries 'registers' and 'flags' from sysfs. Updated ABI file
> >> to reflect this change.
> >>
> >> Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >> Signed-off-by: Asai Thambi S P <asamymuthupa@micron.com>
> >
> > Much nicer, thanks for doing this:
> >
> > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > But, one question on a different sysfs file:
> >
> >> What: /sys/block/rssd*/status
> >> Date: April 2012
> >> KernelVersion: 3.4
> >> Contact: Asai Thambi S P <asamymuthupa@micron.com>
> >> Description: This is a read-only file. Indicates the status of the device.
> >
> > What "status" is this showing? Why is this a sysfs file? Who
> > needs/wants it?
>
>
> This shows the device status - online, write_protect or thermal_shutdown. This
> would be used by management application.

Is it used by a management application? Shouldn't such a tool use the
"standard" block device status files instead? I thought we exported
that information already in the /sys/block/* files.

thanks,

greg k-h


\
 
 \ /
  Last update: 2012-06-05 22:41    [W:1.132 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site