Messages in this thread | | | Subject | Re: [PATCH] perf: Fix intel shared extra msr allocation | From | Peter Zijlstra <> | Date | Tue, 05 Jun 2012 14:07:04 +0200 |
| |
On Tue, 2012-06-05 at 12:38 +0200, Stephane Eranian wrote: > How about we add a field or flag to cpuc to tell it's fake, and then > in > try_alt_er() and __intel_shared_reg_get_constraints() we avoid > touching > live struct (like reg->alloc) if fake==1. I think he was trying to do > the same with the core_id == -1 test.
We might have to do something like that, however I'm trying to figure out when that reg->alloc test in __intel_shared_reg_get_contraints() is useful.
If it is useful in event scheduling, we cannot just leave it out in validate_group().
| |