Messages in this thread | | | Date | Mon, 04 Jun 2012 18:28:09 -0400 | From | Don Dutile <> | Subject | Re: [PATCH 1/2] iommu: dmar: replace printks with appropriate pr_*() |
| |
On 06/04/2012 06:15 PM, Joe Perches wrote: > On Mon, 2012-06-04 at 17:29 -0400, Donald Dutile wrote: >> Replace printk(KERN_* with pr_*() functions. > > Please add > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > before any include and remove the embedded PREFIX > from each printk > >> diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c > > [] > >> break; >> } >> pdev = pci_get_slot(bus, PCI_DEVFN(path->dev, path->fn)); >> if (!pdev) { >> - printk(KERN_WARNING PREFIX >> - "Device scope device [%04x:%02x:%02x.%02x] not found\n", >> + pr_warn(PREFIX "Device scope device" >> + "[%04x:%02x:%02x.%02x] not found\n", >> segment, bus->number, path->dev, path->fn); > > Please don't split any format string. You removed > a space between the scope device and an open bracket. > It's OK for format strings to exceed 80 chars. > > Joe, Thanks for the feeback. I'll incorporate the changes once others have a chance to review & feedback as well.
- Don
| |