Messages in this thread | | | Date | Mon, 4 Jun 2012 17:40:58 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 3/3] uprobes: document uprobe_register() vs uprobe_mmap() race |
| |
On 06/04, Peter Zijlstra wrote: > > On Mon, 2012-06-04 at 16:53 +0200, Oleg Nesterov wrote: > > I didn't check if its my error or not, however: > > > @@ -850,6 +869,10 @@ static int register_for_each_vma(struct uprobe *uprobe, bool is_register) > > > > if (is_register) { > > err = install_breakpoint(uprobe, mm, vma, info->vaddr); > > + /* > > + * We can race against uprobe_register(), see the > > that should be uprobe_mmap(), since this is the register path ;-)
Oops. Fixed. 2/2 is also changed as you suggested.
I'll wait a bit to collect more comments/reviews and resend.
Thanks!
Oleg.
| |