Messages in this thread | | | Date | Mon, 04 Jun 2012 17:41:01 +0200 | From | Jiri Slaby <> | Subject | Re: [PATCH 13/24] TTY: um/line, use tty from tty_port |
| |
On 06/04/2012 05:29 PM, Richard Weinberger wrote: > It looks like that it solves UML's TTY issues with systemd distros. > :-)
Good.
>> So the switch of the driver to the new tty port API, as suggested >> by Alan, is still needed. I might do that later if I learn how to >> make UML work. (The conversion is by definition invasive and >> needs runtime testing.) > > Two days ago I did so but still faced the problems described here: > https://lkml.org/lkml/2012/3/10/163
Hmm, I remember. I suggest you to split the patch into several pieces. For example moving the code from ->open into ->install can be done separately. Otherwise it's hard to tell what's wrong with the patch as a whole.
Also, it would be good to see the patch rebased on the top of my patch, because tty_port_set/get pieces would be gone from your patch too.
regards, -- js suse labs
| |