Messages in this thread | | | From | Ohad Ben-Cohen <> | Date | Mon, 4 Jun 2012 13:06:50 +0300 | Subject | Re: [RFC 3/6] remoteproc: Move fw sanity check to find_rsc_table. |
| |
On Mon, Jun 4, 2012 at 12:56 PM, Sjur BRENDELAND <sjur.brandeland@stericsson.com> wrote: > The sanity_check() is working on the ELF structures. And all ELF > processing needs to be moved to a separate file. So if you want > to keep the call to sanity_check() here, I need to make the > sanity_check() function a separate handler. That could make sense, > but will also bloat the struct rproc_fw_ops with one more function > pointer.
I think it's OK.
Adding another handler is cheap, and if by doing so the code becomes even slightly easier to read or maintain, it's probably worth it.
Thanks, Ohad.
| |