lkml.org 
[lkml]   [2012]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ARM: tegra: apbio: use dmaengine based dma driver
On Friday 29 June 2012 10:34 PM, Stephen Warren wrote:
> On 06/29/2012 05:30 AM, Laxman Dewangan wrote:
>> Use the dmaengine based Tegra APB DMA driver for
>> apbio access in place of legacy Tegra APB DMA.
>>
>> The new driver is selected if legacy driver is not
>> selected and new DMA driver is enabled through config
>> file.
>> +bool tegra_apb_dma_init(void)
>> +{
> ...
>> + tegra_apb_dma_chan = dma_request_channel(mask, NULL, NULL);
>> + if (!tegra_apb_dma_chan) {
>> + pr_err("%s: can not allocate dma channel\n", __func__);
>> + goto err_dma_alloc;
>> + }
> That fires quite a few times during boot, before the DMA driver is
> probed. I think the message should be down-graded to a pr_dbg(). Do you
> agree? I can fix that myself when applying this if you're OK with the
> change.
>

I saw that you already applied it. But for record, I am fine to change
it to pr_debug.

> Aside from that, this looks fine to me.



\
 
 \ /
  Last update: 2012-06-30 17:41    [from the cache]
©2003-2011 Jasper Spaans